From: Xavier Claessens <xclaesse@gmail.com>
Date: Thu, 15 Sep 2011 09:27:11 +0000 (+0200)
Subject: Silently add chat source in the MessageTray
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~7648
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=c23919df15b0b8b1aaf71c6a4441be76650b24a1;p=gnome-shell.git

Silently add chat source in the MessageTray

We don't want the tray bar to open/close quickly when adding a chat because
it happens when user opens the chat from Empathy. The notification will
popup on incoming message anyway.

https://bugzilla.gnome.org/show_bug.cgi?id=657249
---

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 6de4b7a53..9476d7aec 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1495,8 +1495,11 @@ MessageTray.prototype = {
         // after notifications are done showing. However, we don't want that to happen for
         // transient sources, which are removed after the notification is shown, but are
         // not removed fast enough because of the callbacks to avoid the summary popping up.
-        // So we just don't add transient sources to this._newSummaryItems .
-        if (!source.isTransient)
+        // So we just don't add transient sources to this._newSummaryItems.
+        // We don't want that to happen for chat sources neither, because they
+        // can be added when the user starts a chat from Empathy and they are not transient.
+        // The notification will popup on incoming message anyway. See bug #657249.
+        if (!source.isTransient && !source.isChat)
             this._newSummaryItems.push(summaryItem);
 
         source.connect('notify', Lang.bind(this, this._onNotify));